Extra typed breakpoints #430
Conversation
|
Thanks @KrzysztofSikoraCodete. Are you referring to #414? |
|
@jtpio I've just edited description. |
| @@ -11,6 +11,18 @@ import { IDebugger } from '../tokens'; | |||
| * A model for a list of breakpoints. | |||
| */ | |||
| export class BreakpointsModel implements IDisposable { | |||
| /** | |||
| * Get the last breakpoints from story | |||
There was a problem hiding this comment.
Does "story" here refer to the history of breakpoints?
There was a problem hiding this comment.
Exactlly, id which is set here, i use to get current breakpoints from cell's story.
| /> | ||
| ))} | ||
| {breakpoints | ||
| .filter(find => find[0] === model.currentBreakpointsId) |
There was a problem hiding this comment.
Does this mean that we display the breakpoints for the currently selected cell only?
There was a problem hiding this comment.
Or actually the last cell that was updated.
There was a problem hiding this comment.
I think we still want to show the breakpoints for the other cells. To be able to select the cell where the breakpoint is defined when they are clicked.
There was a problem hiding this comment.
How works now
There was a problem hiding this comment.
When adding the breakpoint to the second cell the breakpoint list should show 3 breakpoints:
- 2 for the first cell
- 1 for the second cell
There was a problem hiding this comment.
Sure, I'll figure something out
|
Closed in favor of #454 |
Suggestion to solve the problem
EDIT:
I tried to refer to the suggestion in #414
Sending an empty list by setBreakpont is not a good solution. We lose references when we want to change the breakpoint in the cell.
Every path (id) of breakpoints are actually a reference to the story of all breakpoints in focused, active cell.
What I did is showing the last element from history of them.
My solution would showing breakpoints from active cell. Additionally i have to do a trigger for active cell.
Focus event is not good idea, because doesn't work when user click on breakpoint gutter. However I'll check it.
Next, what i should do is clearing story after a certain number of queries, because all of them stay on memory.