Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Handle switching between two active debug sessions #378

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Handle switching between two active debug sessions #378

merged 2 commits into from
Mar 5, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 4, 2020

Fixes #377.

@jtpio jtpio added this to the 0.2.0 milestone Mar 4, 2020
@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2020

It looks like only the Variable Tree doesn't update itself properly:

variable-tree-update

@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2020

Actually the example is using two different kernels, but the variable names are the same (a and b).

The VariableComponent in the tree view was using the variable name as a key, and since it's the same for both sessions React didn't detect a change.

@jtpio
Copy link
Member Author

jtpio commented Mar 4, 2020

It works for the table viewer because the name, type and value fields are placed in different <td> elements.

@jtpio jtpio marked this pull request as ready for review March 4, 2020 16:04
afshin
afshin approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@afshin afshin merged commit c7f7525 into jupyterlab:master Mar 5, 2020
@jtpio jtpio deleted the notebook-switch branch March 5, 2020 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Switching between notebooks doesn't update the sidebar
2 participants
@jtpio @afshin