You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Glancing at the code, it looks like the EditorFinder (used to find editors matching the temporary cells) is passed all the way down to the EditorHandler here:
Glancing at the code, it looks like the
EditorFinder
(used to find editors matching the temporary cells) is passed all the way down to theEditorHandler
here:debugger/src/handlers/editor.ts
Line 50 in a056c28
And used only once here:
debugger/src/handlers/editor.ts
Lines 163 to 168 in a056c28
This makes editor handlers very coupled to the
EditorFinder
.Moreover the editor finder is passed to the
NotebookHandler
here:debugger/src/handler.ts
Lines 215 to 219 in a056c28
But not to the
ConsoleHandler
andFileHandler
:debugger/src/handler.ts
Lines 221 to 232 in a056c28
Refactoring this should help fix #471 and #414, as a follow-up to #454 (review)
The text was updated successfully, but these errors were encountered: