-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JupyterLab 4.0 #85
Conversation
heroic ❤️ ❤️! I will try to test this tomorrow - and for sure by monday |
Thanks for the epic work, @krassowski! I haven't tested every command, but the updated extension seems to work well. A couple of questions and comments:
|
This is correct. Enabling it in file editor in a follow-up PR should be rather easy.
This is being addressed upstream by jupyterlab/jupyterlab#14796. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff thank you - clearly a lot of work.
I tried it out and aside from the already noted issue originating upstream this is fantastic. If we discover more small bugs going forward they can be fixed in patch releases.
I'd hope to release this soon as the lack of vim seems to have prevented many users from moving to jlab4 (myself included).
@krassowski is there anything more you feel is necessary to add here? If not feel free to self-merge + release (or I can if you'd like)
Feel welcome to merge and release :) |
@krassowski can I check with you that im understanding the release process correctly? It seems as though the right tokens for github release are in place here: jupyterlab-contrib/jupyterlab-contrib.github.io#42 So the steps are:
|
Releaser will update the changelog and version for you, you just specify whether you want a major/minor/patch bump in the workflow dispatch form. |
releaser will either commit to master or open a pr depending on settings not sure now what will happen here. After prep release a draft version will be up in GitHub releases for review. |
Closes #68
Refactors the extension to use @replit/codemirror-vim plugin which is a CodeMirror 6 compatible port of the vim mode from CodeMirror 5.
Notes: