Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openshift documentation #3273

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

willh-cmyk
Copy link
Contributor

@willh-cmyk willh-cmyk commented Nov 24, 2023

Hi, I have a working deployment of the Z2JH working with OpenShift. The docs for deploying JupyterHub to OpenShift link to a repo abandoned in 2019.

I am amending the documentation to point to my working repository here as a way to start this conversation :).

Please let me know if you would prefer that I attempt to merge these changes into the trunk of the Z2JH project, and create documentation for that; or if you would prefer for them to be separate due to the additional requirements OpenShift enforces.

Copy link

welcome bot commented Nov 24, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think linking to your documentation makes sense! OpenShift is different enough from standard K8s that it's not possible to provide support without access to an OpenShift deployment

docs/source/kubernetes/redhat/step-zero-openshift.md Outdated Show resolved Hide resolved
@willh-cmyk
Copy link
Contributor Author

@manics I think it's ready for another look 👍

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manics manics merged commit dce5949 into jupyterhub:main Nov 30, 2023
2 checks passed
Copy link

welcome bot commented Nov 30, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants