Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipynb with newer query parameters and toggles #127

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

jgwerner
Copy link
Contributor

  • Updated text to clarify differences between Canvas Assignments vs Course Custom Field links
  • Toggle JupyerLab vs Classic Notebook launch
  • Toggle LTI 1.1 to reflect standard launch request JupyterHub route

…eld settings

Signed-off-by: Greg <werner.greg@gmail.com>
@welcome
Copy link

welcome bot commented Jun 24, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@yuvipanda
Copy link
Contributor

Thanks, @jgwerner!

May I ask where you found the link to the notebook? We generally recommend folks use https://nbgitpuller.link instead.

@yuvipanda yuvipanda merged commit e93429c into jupyterhub:master Jun 26, 2020
@welcome
Copy link

welcome bot commented Jun 26, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jgwerner
Copy link
Contributor Author

jgwerner commented Jul 1, 2020

Hi @yuvipanda I don’t remember exactly but think I came across it with a search, something like “binder with git” and then just clicked on the binder folder 🏄

@jgwerner
Copy link
Contributor Author

jgwerner commented Jul 1, 2020

Btw I just noticed a typo and sent a PR to fix that :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants