Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link generator: init application type from query params #107

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 2, 2019

This PR allows the nbgitpuller link generator to pre-populate the application type and urlpath from query parameters, just like hub, repo, and branch can be pre-populated.

# this should prepopulate the application choice
https://jupyterhub.github.io/nbgitpuller/link.html?hub=https://my-jupyter-hub.example.com&app=jupyterlab&repo=https://my-gitlab.example.com/<GROUP or USER>/<REPO>

# this should prepopulate application choices to custom and urlpath to something
https://jupyterhub.github.io/nbgitpuller/link.html?hub=https://my-jupyter-hub.example.com&urlpath=/custom/stuff&repo=https://my-gitlab.example.com/<GROUP or USER>/<REPO>

@consideRatio consideRatio merged commit e002f7b into jupyterhub:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant