Error on signup with taken username #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leportella
requested changes
Mar 12, 2020
| user = UserInfo.find(self.db, username) | ||
|
|
||
| def get_user(self, username): | ||
| user = UserInfo.find(self.db, self.normalize_username(username)) |
There was a problem hiding this comment.
If I am not mistaken, if the user doesn't exist it already returns None, so we can remove the following if and just return the result of this search
Comment on lines
172
to
173
| if user: | ||
| return user |
There was a problem hiding this comment.
then this won't be necessary
|
|
||
| def create_user(self, username, pw, **kwargs): | ||
|
|
There was a problem hiding this comment.
can you remove this line to follow patterns please?
|
I asked for a couple of minor things but it looks great! Thanks for your pull request |
|
I have incorporated the changes you pointed out. You were absolutely correct, the |
|
thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91, including an additional test for signing up with the same username multiple times and a fitting error message on rejected signup.
In the course of this, I refactored the
get_or_create_user()method into three methods:user_exists(),get_user()andcreate_user()which gets rid of the signup error (which was related to getting a user when, really, you wanted to create a user).I also replaced calls to UserInfo without username normalization in the authenticator with calls to the aforementioned
get_user(), which does include username normalization.