Automatically deploy ovh ingress for the 'ovh.mybinder.org' certificate #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' and 'binder.mybinder.ovh'
|
Should we write down in the SRE guide why we can't use the "normal" way of getting the certificate so that in a few months we can remember? Otherwise looks good to me. |
|
You're right, I added a small part about that in the SRE guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the OVH k8s instance we need to automatically deploy a specific ingress for serving the correct certificate if user are coming from the
ovh.mybinder.orgurl.I choose to do this outside the helm deployment because it is very specific to the ovh deployment.