Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention updating version in release steps #7

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 27, 2023

I tried to follow the release steps in the README to publish 0.0.2 so we could get the jupyterhub docs passing with #6 , but it didn't mention that the version number needed to be updated (I assumed from the described steps that it was versioneer-style version-from-git, but I was wrong). This also bumps to 0.0.3 so that we can make an 0.0.3 after merge.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! If you think versioneer etc is a better pattern to use I'm happy with whatever!

@choldgraf choldgraf merged commit d4071da into jupyterhub:main Feb 27, 2023
@minrk minrk deleted the release-steps branch February 27, 2023 14:44
@minrk
Copy link
Member Author

minrk commented Feb 27, 2023

Sentiment seems to be largely away from versioneer. I've been trending toward tbump in most places, but I don't have strong feelings myself. I just misread the combination of "Just make a release" with sphinx-theme-builder as an unfamiliar build backend and made an incorrect assumption.

@consideRatio consideRatio added the documentation Improvements or additions to documentation label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants