Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set btn-secondary on dropdown selectors #1915

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

manics
Copy link
Member

@manics manics commented Jan 25, 2025

This ensures you receive visual feedback when you use the keyboard TAB to move between form fields. At present there is no visual indication when you get to a dropdown.

Screencast.From.2025-01-25.14-36-35.mp4

This ensures you receive visual feedback when you use the keyboard TAB to move between form fields. At present there is no visual indication when you get to a dropdown.
@rgaiacs
Copy link
Contributor

rgaiacs commented Jan 27, 2025

Looks good to me.

@minrk minrk merged commit 2ac9124 into jupyterhub:main Jan 27, 2025
16 checks passed
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Jan 27, 2025
jupyterhub/binderhub#1915 Merge pull request #1915 from manics/file-url-visual-indicator
@manics manics deleted the file-url-visual-indicator branch January 27, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants