ci: fix changed resolved ref for dataverse test, fix recent github ratelimit PR #1615
Conversation
| @@ -171,7 +171,7 @@ async def test_hydroshare_doi(): | |||
| [ | |||
| "10.7910/DVN/TJCLKP", | |||
| "10.7910/DVN/TJCLKP", | |||
| "3035124.v3.0", | |||
| "3035124.v4.0", | |||
There was a problem hiding this comment.
@Xarthisius @pdurbin You were involved in the PR that added support for Dataverse and this test in
#969
Is this change in the resolved reference expected? Is there a way to make this constant so it doesn't change again in future?
There was a problem hiding this comment.
@manics hi! Sort of? 😄 I mean, I don't know anything about the test (@Xarthisius might) but I did publish a new version (4) of that 10.7910/DVN/TJCLKP dataset yesterday.
3035124 is the database id of the dataset so that shouldn't change.
I'm not sure if this helps but Dataverse supports the idea of getting the latest published version of a dataset with :latest-published: https://guides.dataverse.org/en/5.12.1/api/native-api.html#datasets ... perhaps this could be a way of avoiding hard coding a value. Please let me know if you have any questions about the Dataverse API or if I can help at all. Thanks for looking into this!
There was a problem hiding this comment.
Is "10.7910/DVN/TJCLKP" associated with v3 or the latest version? Now we get the latest version from that as a reference given to binderhub, when we may or may not have expected we would get v3 even if there was a newer version.
There was a problem hiding this comment.
@consideRatio I'm not sure I'd put it quite that way.
"10.7910/DVN/TJCLKP" is associated with all versions of the dataset, including the latest version and previous versions (v3, v2, etc). Dataverse doesn't mint DOIs for each version of a dataset (though this functionality has certainly been requested for quite a while).
I still think :latest-published (above) might help but there's also a Dataverse API to list each version of a dataset, if that's of interest: https://guides.dataverse.org/en/5.12.1/api/native-api.html#list-versions-of-a-dataset
Sorry if I'm not quite following. If you're getting the latest version from "10.7910/DVN/TJCLKP" I'm not sure why v3 is hard coded (and updated to v4 in this PR).
There was a problem hiding this comment.
IQSS/dataverse#4499 explains it, I assumed Dataverse supported exact DOIs resolving to a particular version for reproducibility 😞 .
I can think of two options here (I'm happy with whatever you prefer):
- Change this to
v4as in the PR - Change this (and the test case below) to a regex match for
v\d+
Either way, adding a comment to this test case explaining all this would be helpful for future readers!
There was a problem hiding this comment.
@manics if I get a vote, I much prefer the regex option. Publishing a new version of my dataset shouldn't break anything. 😄
There was a problem hiding this comment.
Regex added and I've included a comment based on your comment here @pdurbin - thank you!!
c286f3c to
dfd3376
Compare
b492387 to
1990c64
Compare
🚀Co-authored-by: Simon Li <orpheus+devel@gmail.com>
jupyterhub/binderhub#1615 Merge pull request #1615 from consideRatio/pr/fix-dataverse
There was a new version of a DOI that was tested against, so "resolved_ref" transitioned from v3.0 to v4.0 it seems. The last update to this DOI was several years ago. I've made it into a regexp now though so if new releases happen, it should not break this again.
Closes Dataverse test failure in main branch #1614
Complements ci: set GITHUB_ACCESS_TOKEN to temporary read only token #1612 with a typo fix, and with that, our test suite should become reliable I think