helm-chart: minor refactoring of syntax #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
consideRatio
commented
Oct 10, 2021
- helm-chart: consistent use of with
- helm-chart: don't use trimSuffix after toYaml, not needed
23 tasks
consideRatio
commented
Oct 10, 2021
Comment on lines
-15
to
17
| {{- range $key, $value := .Values.ingress.annotations }} | ||
| {{ $key }}: {{ $value | quote }} | ||
| {{- with .Values.ingress.annotations }} | ||
| {{- . | toYaml | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
The old pattern has been useful in the past to enforce passed values are strings, but we now have a schema to force users to make their annotations strings in the first place - so we can now use toYaml without additional interventions.
consideRatio
commented
Oct 10, 2021
| {{- end }} | ||
| {{- end }} | ||
| spec: | ||
| {{- with .Values.ingress.ingressClassName }} | ||
| ingressClassName: "{{ . }}" | ||
| ingressClassName: {{ . | quote }} |
There was a problem hiding this comment.
I don't care much about this, I just wanted consistency within this file.
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 11, 2021
jupyterhub/binderhub#1419 Merge pull request #1419 from consideRatio/pr/refactor-templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.