helm-chart: bump Ingress k8s apiVersion #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
527f2c8 to
092dfbf
Compare
092dfbf to
2a3930b
Compare
sgibson91
approved these changes
Oct 7, 2021
|
This was blocking additional work I wanted to contribute with, so given the approval I went for a merge to make the next PR! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 7, 2021
jupyterhub/binderhub#1407 Merge pull request #1407 from consideRatio/pr/bump-and-fix-ingress
This was referenced Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one to close #1396, fixes the Ingress resource.
Note that this blocks another PR I want to make, and this PR itself could benefit from being tested via #1392.