Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unique loggers #45

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Ensure unique loggers #45

merged 2 commits into from
Apr 10, 2020

Conversation

blink1073
Copy link

Fixes #44.

@Zsailer if you could please add me as a maintainer on https://pypi.org/project/jupyter-telemetry I can cut a release.

Support python 3.5

flake8
@yuvipanda yuvipanda merged commit 24b5aba into jupyter:master Apr 10, 2020
@yuvipanda
Copy link
Collaborator

Thanks for the PR @blink1073! I've merged this, and given you rights on pypi as well.

@blink1073
Copy link
Author

Thanks @yuvipanda! It looks like it didn't go through. My username is blink1073 there as well.

HTTPError: 403 Client Error: The user 'blink1073' isn't allowed to upload to project 'jupyter-telemetry'.

@blink1073
Copy link
Author

cc @Zsailer ^^

@Zsailer
Copy link
Member

Zsailer commented Apr 10, 2020

@blink1073, done!

@blink1073
Copy link
Author

...and released, cheers!

@Zsailer
Copy link
Member

Zsailer commented Apr 10, 2020

@blink1073, great stuff! Thank you, and welcome to the jupyter telemetry team! 🚀 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventLog is using a shared logger instance
3 participants