Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding timestamp of event #43

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Allow overriding timestamp of event #43

merged 1 commit into from
Feb 13, 2020

Conversation

yuvipanda
Copy link
Collaborator

Very useful when generating eventlog streams from pre-recorded
data.

Fixes #42

Very useful when generating eventlog streams from pre-recorded
data.

Fixes #42
@yuvipanda yuvipanda requested a review from Zsailer February 12, 2020 09:41
@Zsailer
Copy link
Member

Zsailer commented Feb 12, 2020

Thanks, @yuvipanda! This looks great!

Quick follow up question—is it dangerous effect/override timestamps of events? I think, as long as we're not exposing this functionality to operators and users (i.e. through some configurable option etc), it should be safe, right? We don't want people changing timestamps to obfuscate their activity in some way.

@yuvipanda
Copy link
Collaborator Author

https://github.com/yuvipanda/jupyterhub-telemetry-extractor is the code I wrote! Pushes out telemetry logs from parsing JupyterHub logs.

@yuvipanda
Copy link
Collaborator Author

@Zsailer I don't think this PR changes our security posture. For examples, admins can put in loggers with custom handlers that can change timestamps (or any other data) as they wish. If users are running code in the same python process (as we do with notebooks most of the time), they can also monkeypatch easily to do the same thing. So we should continue treating all telemetry from user created processes as untrusted, regardless of what happens with this PR...

@Zsailer
Copy link
Member

Zsailer commented Feb 13, 2020

we should continue treating all telemetry from user created processes as untrusted

👍 Sounds good. This looks good to me!

@Zsailer Zsailer merged commit ede6d17 into jupyter:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding event timestamps
2 participants