Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qtconsoleapp.py #12

Closed
wants to merge 1 commit into from
Closed

Update qtconsoleapp.py #12

wants to merge 1 commit into from

Conversation

183amir
Copy link

@183amir 183amir commented May 27, 2015

Fixes #11
I did a quick test on my machine and it seems to work.

@Carreau
Copy link
Member

Carreau commented May 27, 2015

Hum, with the renaming to Jupyter, I'm not sure IPython a the right choice :-)

@takluyver
Copy link
Member

I think we need to work out what's going on a bit better:

  • On my machine, I already see an application title in GNOME shell, without this change. Though it differs depending on if I start it from the command line or from a launcher. Which way are you starting it?
  • The guide you posted said that the name needs to match the name of a .desktop file. That will probably be ipython-qtconsole or ipython3-qtconsole.
  • @ccordoba12 reckons there's a similar issue on KDE; it would be good to know if that's the same or something else.

@ccordoba12
Copy link
Collaborator

This is the issue reported in our side about our lack of WM_CLASS: spyder-ide/spyder#2207.

According to the OP (a KDE developer), it was causing Spyder to be grouped with the wrong app in Plasma's taskbar. So there are other side effects besides the one reported on issue #11.

@takluyver
Copy link
Member

OK, so it looks like we should be calling self.app.setApplicationName() as well. The GNOME docs also say that the name should match the filename of the .desktop file, minus .desktop, which will be jupyter-qtconsole by the next release, I guess. I'm going to whistle up another PR with the changes I think are necessary.

takluyver added a commit to takluyver/qtconsole that referenced this pull request Jun 5, 2015
From the information I've seen, I think this is right, but I can't test
it on GNOME 3 for a few more days.

Closes jupyter#12
Closes jupyter#11
@takluyver
Copy link
Member

See #16

@takluyver takluyver closed this in #16 Jun 8, 2015
@minrk minrk modified the milestone: no action Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The value of WM_CLASS in IPython qtconsole is empty.
5 participants