Add show_banner to ignored_traits #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2023
|
Looks like the CI failure might not be relevant, but would still be good to address before a new release? |
|
Thx @jtpio CI is green now. |
Zsailer
approved these changes
Apr 24, 2023
|
Looks good. Thanks @echarles |
|
Thx @Zsailer Is it possible to get a release with this PR? |
|
Yeah, happy to cut the release. You should have permissions too—it looks like all notebook team members are listed as admin on this repo. |
|
I am not listed on pypi for notebook_shim, I let you cut the release this time. Thx. |
|
Ah, I see. Just added you as a maintainer on the PyPi package. Released: https://github.com/jupyter/notebook_shim/releases/tag/v0.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to jupyter/nbclassic#242
Once this is merged and released, jupyter/nbclassic#243 needs to be upated.