-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load custom CSS #6841
Merged
Merged
Load custom CSS #6841
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
adea3c7
wip loading custom css
RRosio 06c8c43
read css file from profile directory and apply
RRosio 9cf953e
update css handler, add CLI flag to disable custom CSS, documentation
RRosio 619e7f6
import ExtensionAppJinjaMixin
RRosio 23e55b3
remove ExtensionAppJinjaMixin as a JupyterNotebookApp base class
RRosio 0eeebdb
add type hint to ignore jinja2_env type
RRosio e99e1a3
fix prettier issue in docs
RRosio 31fd302
Merge branch 'main' into custom_css
RRosio eb7ff71
add empty line; trigger new docs build
RRosio ae7badc
new line caused prettier error, remove
RRosio 594e678
move custom css to different directory and update handler
RRosio 2793e45
modify regex
RRosio f76c807
satisfy mypy: check for match in regex before grabbing the directory …
RRosio d56964d
load custom css in consoles page
RRosio e851069
Merge branch 'main' into custom_css
RRosio 3cb5ecd
Merge branch 'main' into custom_css
RRosio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/* | ||
Placeholder for custom user CSS | ||
|
||
mainly to be overridden in profile/static/custom/custom.css | ||
|
||
This will always be an empty file | ||
*/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up (could be another PR), maybe it could be interesting to document the feature more (for example in the user guide), to show an example of such
custom.css
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jtpio I can follow this PR up with one that includes the example!