Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update marked to 0.5 #4046

Merged
merged 2 commits into from
Oct 10, 2018
Merged

update marked to 0.5 #4046

merged 2 commits into from
Oct 10, 2018

Conversation

surya-prakash-susarla
Copy link
Contributor

@surya-prakash-susarla surya-prakash-susarla commented Sep 27, 2018

Changed 'marked' dependency version to 0.5 August release for fixing rendering bugs of formatted markdown cells.

closes #3874

Changed marked version to 0.5 August release for fixing rendering bugs.
@jasongrout
Copy link
Member

For reference, see #3874

@surya-prakash-susarla
Copy link
Contributor Author

@jasongrout Is the pr fine ?

@jasongrout
Copy link
Member

I restarted the testing. It looks okay to me, but I haven't tested it.

@surya-prakash-susarla
Copy link
Contributor Author

@jasongrout Hey, the travis ci build fails as per the checks. Is it because of this minor change? Could you please suggest how I might solve any issue from my side.

@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 29, 2018

Hey @Surya-06 , the problem is not from your side, its with the test.
check #4039 for the fix of travis's tests.
Enjoy!

@surya-prakash-susarla
Copy link
Contributor Author

@Hyaxia Hey there, thanks for the update. Can you guide me on how to fix the tests, I am a newbie and don't know how to configure the tests for each PR.

Changed attr value of travis tests to fix the failing tests in PR.
@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 29, 2018

@Surya-06 It looks like you have made the right changes to the travis-ci configuration.
There is another problem ATM, with the appveyor tests.
It looks like there is some kind of problem with the setuptools/pip itself.
check #4039 for updates on the matter.

@surya-prakash-susarla
Copy link
Contributor Author

@Hyaxia Yeah it looks like there some issue with the miniconda package attributes which triggers that whole chain of exceptions.

@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 30, 2018

@Surya-06 see my temporary fix for the bug 4c1d62f
It seems like there is a problem with the current of nbconvert or its dependencies that
anaconda installs, so we just use pip instead.

@minrk minrk changed the title (Issue #3874 ) : Fix for problem with rendering of formatted markdown cells update marked to 0.5 Oct 10, 2018
@minrk minrk added this to the 6.0 milestone Oct 10, 2018
@minrk minrk merged commit dab6046 into jupyter:master Oct 10, 2018
@minrk
Copy link
Member

minrk commented Oct 10, 2018

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with rendering of formatted markdown cells
4 participants