Skip to content

Commit

Permalink
relax busy/idle ordering on reconnect
Browse files Browse the repository at this point in the history
nudge can leak idle messages, so it could be busy->idle, or idle->busy->idle.

The important thing is that we get at least one idle message
  • Loading branch information
minrk committed Dec 17, 2020
1 parent b4f5f6b commit f716328
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions notebook/tests/services/kernel.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,9 @@ casper.notebook_test(function () {
'kernel_disconnected.Kernel',
'kernel_reconnecting.Kernel',
'kernel_connected.Kernel',
'kernel_busy.Kernel',
'kernel_idle.Kernel'
// note: there will be a 'busy' in here, too,
// but we can't guarantee which will come first
'kernel_idle.Kernel',
],
function () {
this.thenEvaluate(function () {
Expand All @@ -262,8 +263,7 @@ casper.notebook_test(function () {
'kernel_connection_failed.Kernel',
'kernel_reconnecting.Kernel',
'kernel_connected.Kernel',
'kernel_busy.Kernel',
'kernel_idle.Kernel'
'kernel_idle.Kernel',
],
function () {
this.thenEvaluate(function () {
Expand Down

0 comments on commit f716328

Please sign in to comment.