-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document_info to schema #46
Conversation
"metadata": {}, | ||
"nbformat": 4, | ||
"nbformat_minor": 0, | ||
"document_info": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we likely want title and author directly in the metadata section instead of a new top level key.
"metadata": {
"author": "Jean Tester",
"title": "Test Notebook"
}
Thanks for taking the lead on this! |
Expressing multiple authors with schema.org JSONLD:
{"@context": ["http://schema.org/", {"jupyter": "https://jupyter.org/ns/#" }],
"@type": ["CreativeWork", "jupyter:JupyterNotebook"],
"metadata": {
"name": "Jupyter Notebook Title",
"author": [
{"@type": "Person",
"name": "Author 1"},
{"@type": "Person",
"familyName": "lastname",
"givenName": "firstname",
"worksFor": {"@type": "Organization", "name": "UniversityXYZ"},
"affiliation": {"...":"..."},
"url": "..."}
],
"funder": [{"name": "UniversityXYZ"],
"license": "https://creativecommons.org/licenses/by-sa/4.0/",
"license": {"@type": "CreativeWork",
"name": "CC by-SA 4.0",
"url": "https://creativecommons.org/licenses/by-sa/4.0/"},
} See also:
|
Thanks, @captainsafia! I agree with @rgbkrk's comment (also see discussion in #45) that I'd prefer this to add a definition for metadata fields: |
Updated. |
Could we please do
On Friday, September 9, 2016, Safia Abdalla notifications@github.com
|
I'm hesitant to use name instead of title as it's fairly ambiguous, especially now that this document-specific info is stored in the |
Here's this, which is forked from your pull:
|
I think title is a better choice for the title of a document. name is ambiguous, because it is easily confused with the filename, etc, and we intend to use this field specifically for title purposes. If the document went on nbviewer, etc. this is the string that would go in cc @ellisonbg and @fperez who have expressed interest in title/author metadata |
"description": "The title of the notebook document", | ||
"type": "string" | ||
}, | ||
"author": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
author probably needs to be a list of authors with a few fields, as described in #45 (comment)
I disagree. I think that, if the objective is to store metadata that will On Monday, September 12, 2016, Min RK notifications@github.com wrote:
|
On Monday, September 12, 2016, Wes Turner wes.turner@gmail.com wrote:
|
I agree with @minrk that "title" is a much better way of spelling this out. Also authors should be a list. Fully in favor of this though! |
}, | ||
"author": { | ||
"description": "The author(s) of the notebook document", | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minrk @ellisonbg does it need to be a literal list or can a string suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially if we are tackling Latex Export, I think it should be a list of object. Authors can have emails, phones affiliations, and be corresponding authors. Making it objects, leave it flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List<Object>
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From #46 (comment):
This makes author a list edit: (and adds a few properties which could be used for author metadata form generation): westurner/nbformat@c298b08
I agree. This makes |
Welp! Sorry for the delay. Updates are now present in PR. The only piece of data required for author is the name so we don't place too many requirements on users off the bat. |
"type": "string" | ||
} | ||
}, | ||
"additionalProperties": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this gives us the flexibility to provide other fields later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Woo! |
#91 "Store notebook title/name in metadata" |
This adds a document_info object to the schema to hold the title and author of the document.
cc: @minrk @rgbkrk