[WIP] Run coroutines in another thread for blocking API #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MSeal this seems like the deadlock issue you were mentioning, |
|
Yep -- this is basically guaranteed with os threading ontop of forking at the same time because, among other reasons, the os replicates thread local context that's invalid. |
|
Is there anyway we can apply or not apply nest_asyncio and catch the exception to switch modes automatically instead of introducing more concurrent patterns in-place? |
|
Yes, we can try without nest_asyncio and if we catch the exception try again with it. Thanks, I'll open a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get rid of nest_asyncio (see nteract/papermill#490).