Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static and templates folder are not present in the release #204

Closed
echarles opened this issue Jan 25, 2023 · 5 comments · Fixed by #205 or #206
Closed

static and templates folder are not present in the release #204

echarles opened this issue Jan 25, 2023 · 5 comments · Fixed by #205 or #206

Comments

@echarles
Copy link
Member

Probably a consequence of #181, the static and templates folders are no more present in the release (https://pypi.org/project/nbclassic/0.5.0 had to be yanked).

static and templates folder are however present further a pip install . (also present in editable mode with ``pip install -e .`).

cc/ @blink1073

@blink1073
Copy link
Contributor

Because they are in .gitignore they must be manually included, as we do in jupyter_server.

@echarles
Copy link
Member Author

Thx @blink1073 I have opened #204

@echarles
Copy link
Member Author

@blink1073 I have tested locally with the merged #204, running python -m build and the generated wheel does not contain the static nor templates. I am expecting that the release will also not contain them. Any idea?

@echarles echarles reopened this Jan 25, 2023
@echarles
Copy link
Member Author

components was present in .gitignore, but not templates. I guess the change of #204 has not modified the behavior.

I have tried to tune MANIFEST.in without luck. I am going to continue to search. If I can not find a solution in the short term and as users are waiting for a release (with CVE fixes) I guess I will open a PR to temporary revert #181

@echarles
Copy link
Member Author

Ok, I have a fix with #206 (at least python -m build creates a correct wheel on my env with the templates and static folders).

@blink1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants