This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Ensure request-timeout is > launch-timeout + pad #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a default of 40 seconds for KERNEL_LAUNCH_TIMEOUT and a pad value of 2 seconds that can be changed via KG_LAUNCH_TIMEOUT_PAD. The manager code (where kernel starts occur) ensures that KG_REQUEST_TIMEOUT is at least KERNEL_LAUNCH_TIMEOUT + KG_LAUNCH_TIMEOUT_PAD. Fixes jupyter#36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default of 40 seconds for KERNEL_LAUNCH_TIMEOUT and a pad
value of 2 seconds that can be changed via KG_LAUNCH_TIMEOUT_PAD.
The manager code (where kernel starts occur) ensures that
KG_REQUEST_TIMEOUT is at least KERNEL_LAUNCH_TIMEOUT + KG_LAUNCH_TIMEOUT_PAD.
Fixes #36