This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Update handlers.py #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If message is bytes, we should set binary=True
kevin-bates
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
This change makes total sense - thank you!
Since NB2KG is embedded directly in Notebook 6.0, could you please make the similar change here?
Thank you.
|
Yes, I'm glad to do it. |
lresende
pushed a commit
to jupyter/notebook
that referenced
this pull request
Jun 25, 2019
If the message is bytes, we should set binary=True This is a port from NB2KG PR jupyter/nb2kg#33
kevin-bates
pushed a commit
to kevin-bates/jupyter_server
that referenced
this pull request
Sep 23, 2019
If the message is bytes, we should set binary=True This is a port from NB2KG PR jupyter/nb2kg#33
kevin-bates
pushed a commit
to kevin-bates/jupyter_server
that referenced
this pull request
Sep 26, 2019
If the message is bytes, we should set binary=True This is a port from NB2KG PR jupyter/nb2kg#33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue #26