Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new release on PyPi #167

Closed
s-weigand opened this issue Sep 28, 2018 · 11 comments
Closed

Make a new release on PyPi #167

s-weigand opened this issue Sep 28, 2018 · 11 comments

Comments

@s-weigand
Copy link
Contributor

The current version of jupyter-console on PyPi (5.2.0, Aug 21, 2017 ) is breaking the jupyter installation (see #166 ), because of the dependency conflict in prompt-toolkit with ipython>=7.0.
Thus a new version should be released on PyPi, to prevent users from having touble.

Also a check of the ipython version on installation would be good, to inform user of legacy ipython ipython<7.0 that they need to install jupyter-console<=5.2. Or at least set min python version to 3.5 so it compatible with ipython>=7.0 . I don't know what the best tactics is for this.

@s-weigand
Copy link
Contributor Author

s-weigand commented Oct 1, 2018

Since i saw it come up some times by now, there are two temporary workarounds (after running pip install jupyter):

  1. Downgrade ipython:
    pip install -U 'ipython<7.0'
  2. Upgrade jupyter-console to current master:
    pip install git+https://github.com/jupyter/jupyter_console

@vmehera123
Copy link

vmehera123 commented Oct 1, 2018

@s-weigand doesn't work on fresh ubuntu 18.04

Since i saw it come up some times by now, there are two temporary workarounds:

  1. Downgrade ipython:
    pip install -U ipython<7.0
  2. Upgrade jupyter-console to current master:
    pip install git+https://github.com/jupyter/jupyter_console

@s-weigand
Copy link
Contributor Author

My bad, I forgot the ' around the ipython<7.0, now that i corrected it, it should work.
I just tested it on a fresh installed Ubuntu 18.04 virtual box, with 2 different minimal conda envs (python 3.6) and both methods did work (ipython and jupyter-console did run). Note for the 2. solution you need git installed (sudo apt install git -y on ubuntu).

Can you please, tell ous which commands you did run, what the output was and what exactly didn't work? Also the result of pip freeze before and after might be interesting. Guess the best place to post that information would be #158 .

Thanks for telling us 😃

@blink1073
Copy link
Contributor

@Carreau @ivanov if you add me to PyPI I can make a release later today.

@blink1073
Copy link
Contributor

(blink1073)

@Carreau
Copy link
Member

Carreau commented Oct 2, 2018 via email

masterDev1985 pushed a commit to masterDev1985/indy-sdk that referenced this issue Oct 2, 2018
I followed the advice here:
jupyter/jupyter_console#167 (comment)
in order to patch the getting started tutorial to work until upstream
changes are made to Jupyter to fix its dependency issues.
@blink1073
Copy link
Contributor

Yep, I got the email from PyPI

@blink1073
Copy link
Contributor

6.0 is available on PyPI and working nicely with pip install jupyter in a clean conda environment. However, I also released an errant 5.4.0 that I don't have the ability to remove...

@blink1073
Copy link
Contributor

Conda release in flight: conda-forge/jupyter_console-feedstock#10

@dsblank
Copy link
Member

dsblank commented Oct 15, 2018

Thanks all! Can this be closed?

@blink1073
Copy link
Contributor

Yep! I made #174 to track my errant release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants