Update test kernel with native coroutine, remove async_generator dependency #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
approved these changes
Apr 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating the Kernel Provisioning PR with all of the recent changes, I ran into a couple of general issues that appear related to some recent updates to ipykernel (
6.0a5). Since we're using the--preoption to install test dependencies, I thought I'd add these changes to the primary branch since, in all likelihood, the next PR will encounter them.SignalTestKernelto use a native coroutine that is used inTestKernelManagerShutDownGracefully.async_generator-decorated method has been removed (as hasyield_) since we no longer support Python 3.5.TestKernelManagerShutDownGracefullytests that useshutdown_requeston Python 3.6 since theipykernelupdates are not available in that Python release. These changes are essentially mutually exclusive to those in item 1, so this PR errs on the side of Python 3.7+.