Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin python>=3.6.1 #636

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Pin python>=3.6.1 #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ def run(self):
'Operating System :: OS Independent',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this py3.5 change but just confirming that py3.9 is being tested:

jupyter_client/.github/workflows/main.yml

Line 41 in 018d8da

python-version: [3.6, 3.7, 3.8, 3.9]

👍

],
install_requires=[
'traitlets',
Expand All @@ -76,7 +76,7 @@ def run(self):
'tornado>=4.1',
'nest-asyncio>=1.5',
],
python_requires='>=3.5',
python_requires='>=3.6.1',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So anyone using 3.5 with 6.1.13 will still have issues. What's the plan there? Does 6.1.13 get revoked/blacklisted somehow and then this change goes into a new 6.2 release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, v6.1.13 has been marked as broken on conda-forge, and I'm waiting for someone with management rights to yank it on PyPI.
When we merge this PR, I will release v6.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbrochart I can yank 6.1.13. Do you want me to wait for the 6.2 release before yanking? Usually you want a roll-forward option before removing a dep, especially when it's not a security issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbrochart 6.1.13 is yanked. You should have permission on PyPI for this as well (let me know if you don't see the option)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matthew. Unfortunately I still don't see admin permission on PyPI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aww I think I see the issue. Should be fixed now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, thanks!

extras_require={
'test': [
'async_generator',
Expand Down