Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Travis CI, add GitHub Actions #586

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Conversation

davidbrochart
Copy link
Member

No description provided.

@davidbrochart
Copy link
Member Author

In my branch I can see two failures on macos with python 3.8 and 3.9:

../../../hostedtoolcache/Python/3.8.6/x64/lib/python3.8/multiprocessing/popen_spawn_posix.py:47: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

obj = <Process name='Process-4' parent=4583 initial>
file = <_io.BytesIO object at 0x11276ea40>, protocol = None

    def dump(obj, file, protocol=None):
        '''Replacement for pickle.dump() using ForkingPickler.'''
>       ForkingPickler(file, protocol).dump(obj)
E       AttributeError: Can't pickle local object 'ArgumentParser.__init__.<locals>.identity'

../../../hostedtoolcache/Python/3.8.6/x64/lib/python3.8/multiprocessing/reduction.py:60: AttributeError

I will just exclude these ones for now.

@davidbrochart
Copy link
Member Author

davidbrochart commented Nov 6, 2020

Also, the windows tests never start, so I removed windows testing.

@davidbrochart
Copy link
Member Author

davidbrochart commented Nov 6, 2020

Works fine now. I guess this is fine, since we're already testing more environments than previously with Travis CI.
BTW, I dropped python 3.5 and added 3.9.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit aa253c2 into jupyter:master Nov 6, 2020
@davidbrochart davidbrochart deleted the gha branch November 6, 2020 17:15
@kevin-bates kevin-bates mentioned this pull request Feb 2, 2021
@kevin-bates kevin-bates mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants