Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup() args for new pypi.org #357

Merged
merged 5 commits into from
Mar 12, 2018
Merged

Add setup() args for new pypi.org #357

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac9c2e9
Add metadata for new pypi.org
willingc Mar 11, 2018
bcede57
Changes from @takluyver @minrk review
willingc Mar 12, 2018
f498173
Fix OS classifier
willingc Mar 12, 2018
bad02e9
Fix Python version
willingc Mar 12, 2018
08a9f65
one more time
willingc Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,22 +60,35 @@ def run(self):
name = name,
version = version_ns['__version__'],
packages = packages,
description = "Jupyter protocol implementation and client libraries",
description = 'Jupyter protocol implementation and client libraries',
author = 'Jupyter Development Team',
author_email = 'jupyter@googlegroups.com',
url = 'https://jupyter.org',
license = 'BSD',
platforms = "Linux, Mac OS X, Windows",
keywords = ['Interactive', 'Interpreter', 'Shell', 'Web'],
project_urls = {
'Documentation': 'https://jupyter-client.readthedocs.io',
'Source': 'https://github.com/jupyter/jupyter_client/',
'Tracker': 'https://github.com/jupyter/jupyter_client/issues',
},
classifiers = [
'Framework :: Jupyter',
'Intended Audience :: Developers',
'Intended Audience :: Education',
'Intended Audience :: System Administrators',
'Intended Audience :: Science/Research',
'License :: OSI Approved :: BSD License',
'Operating System :: MacOS',
'Operating System :: Microsoft :: Windows',
'Operating System :: POSIX :: Linux',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect it to work on any platform where Python and ZMQ are available, which is probably a much bigger group than these three. Maybe use Operating System :: OS Independent instead? Or leave it out altogether - I think OS-independent is the default assumption for Python modules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

'Programming Language :: Python',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I harp on about this, but my preference is to use the 2 and 3 classifiers and leave the more specific ones out. They only get out of date, as these have.

The python_requires parameter, which I see you've also added, is a better way of conveying which minor versions it's meant to work with.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I went back and forth on this myself. I will go with your suggestion @takluyver.

],
install_requires = [
'traitlets',
Expand All @@ -85,6 +98,7 @@ def run(self):
'entrypoints',
'tornado>=4.1',
],
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, <4',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be optimistic and remove '<4' here. Putting this here prevents people from even attempting to install the package with a hypothetical Python 4 without us making a new release.

extras_require = {
'test': ['ipykernel', 'ipython', 'mock'],
'test:python_version == "3.3"': ['pytest<3.3.0'],
Expand Down