Improve performance of get_kernel_spec #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
approved these changes
Dec 15, 2017
Carreau
added a commit
that referenced
this pull request
Dec 15, 2017
Backport PR #311 on branch 5.x
takluyver
added a commit
to takluyver/jupyter_client
that referenced
this pull request
Dec 16, 2017
blink1073
pushed a commit
to blink1073/jupyter_client
that referenced
this pull request
Aug 3, 2021
blink1073
pushed a commit
to blink1073/jupyter_client
that referenced
this pull request
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids doing a full scan of kernel specs each time
get_kernel_spec()is called. It only looks for the resource directory it needs, saving some unnecessary stat calls.A caching solution could improve performance even more, but would be much more complex - this collects the low-hanging fruit.