-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CI and drop py3.7 #236
Conversation
@akhmerov can you please add |
.github/workflows/tests.yml
Outdated
tests: | ||
|
||
strategy: | ||
matrix: | ||
python-version: [3.7, 3.8] | ||
python-version: ["3.8", "3.11", " 3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why you are not testing all python version on ubuntu and only latest on extra platform (mac and windows). This is what I have been doing so far in other repo but now I'm questioning myself....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
Fix #230 |
@akhmerov if you can add |
@blink1073 done! @12rambau I see this: |
@blink1073 @12rambau thank you for stepping in! |
You are right, I'm "borntobealive" over there (same knight avatar if it helps) |
@blink1073 another RTD-related issue: the webhook integration listed here needs to be updated with a secret, and I cannot do this because of not having sufficient github permissions for this repo. |
Thanks @akhmerov, I created a new webhook, and it is working now |
@blink1073, Is this ready to merge or you have other requests related to the build ? |
Yes, but in follow up PRs. :) |
Python 3.7 is EOL. Clean up CI and test all current Python versions.
Update readthedocs config.
Fixes #230. Fixes #232