-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voila incorporation #42
Conversation
To be explicit with my "approval", I both approve the document (reviewed it for typos and think it's ready for merge) and vote in favor of accepting the proposal. 😄 I'm not sure how to best signal those two actions on Github. |
Should we use this JEP to test drive the JEP Process? Instead of winging it without a process. I say test drive because JEP-29 has been merged but is still marked as draft. If the status should be "accepted" then read this as a reminder that there is a process that should be used ;) |
Thanks @betatim. It does not seem that the new process provides a method to incorporate existing projects as subprojects though. The new jupyter_server proposal is pretty much going through the new process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really excited about this.
There are two files which look ~identical at a glance. Is that deliberate? 😕 |
There seems to have been a rebasing issue. Fixing this now. |
done. |
I approve |
Sorry for the delay @SylvainCorlay - I abstain from this vote. |
To summarize the results of the votes:
Also, many thanks to @Zsailer, @bollwyvl, @lheagy, @jtpio, @martinRenou for reviewing the JEP PR and approving the proposal! |
Sounds like we've passed with flying colors. Thanks! |
We propose to make Voilà an official Jupyter subproject.