Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections to spelling, grammar #39

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

parente
Copy link
Member

@parente parente commented Mar 6, 2019

Some of these might already be corrected in #38.

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to merge and perhaps @choldgraf can rebase his changes against yours.

@choldgraf
Copy link
Contributor

I'm happy to rebase! I'd merge but don't have permissions to do so!

@parente parente merged commit 4eb4ba1 into jupyter:master Mar 7, 2019
@parente
Copy link
Member Author

parente commented Mar 7, 2019

Ah sorry. Thought ya’ll had permissions. On that note, do we have a plan for who should have ownership on this repo to merge and do general admin? Maybe it’s part of the meta JEP and I’m not remembering. If not, should we call that out explicitly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants