-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mamba instead of conda in spark images #1351
Conversation
I'm switching to mamba for pyspark and all-spark images, so I will write what changes during install steps for these two images. |
Current master build: https://github.com/jupyter/docker-stacks/runs/2719734258 pyspark
|
Current PR build: https://github.com/jupyter/docker-stacks/pull/1351/checks pyspark mamba install: https://github.com/jupyter/docker-stacks/pull/1351/checks#step:5:6073
|
After cleaning up the same things:
mamba:
I have no idea, why conda updates python (I noticed it today and created an issue #1352). |
@wolfv maybe you know, why are there differences between conda and mamba? |
There are usually a bunch of "working" solutions and the optimization criteria is not exactly clear. From the installation list I would suspect that both solutions would work almost equally well? |
I will check (I have never used pyarrow package, so I will try to find some good example). Also, there is a reproducible example now (you asked for that in another PR) and the diff is almost like the one I gave:
|
I've just analyzed a similar "issue" over here: mamba-org/mamba#924 |
I think you're right and I do like more minimal installation of mamba. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent to me! I absolutely support this change based on previous experience of doing this change in other projects, especially now that you have covered the differences explicitly.
Thank you so much for your work on this @mathbunnyru and thank you @wolfv for mamba and your input now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thanks for this change. My opinion is let's try it since the tests are OK.
We have tests loading packages and also a test involving arrow that has been written in the frame of the issue #1198.
If issues are reported we will add corresponding tests and rollback to conda it's pretty easy to do.
Best
Great, thanks, let's try it out! |
I decided to try mamba separately and I will take a look what changes when using mamba.
Fix: #1352