Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Add declarative widgets jar to release #468

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Add declarative widgets jar to release #468

merged 2 commits into from
Jul 27, 2016

Conversation

poplav
Copy link
Contributor

@poplav poplav commented Jul 22, 2016

Fixes #455:

  • Utilizes the sbt-sonatype plugin
  • The env variables added to travis are:
    • encrypted_9067f25a9380_key, encrypted_9067f25a9380_iv used in the travis before_install target to decrypt the encrypted secret file hosted in github
    • PGP_PASSPHRASE passphrase for the secret once it is decrypted
    • REPO_USERNAME, REPO_PASSWORD nexus username/password
  • When issuing a new release the only change would be to modify the version := variable in kernel-scala/build.sbt
  • Can search/view the packages released/hosted on search.maven.org
  • Tested and can utilize in a notebook e.g. %AddDeps org.jupyter declarativewidgets_2.10 0.6.1_dev --transitive --trace --verbose
  • Todos
    • Still need to update the release process wiki. Was holding off to document after an official release, as the testing that was done so far was replacing make all with make publish-scala-jar in travis.
    • Comment of the sonatype issue that a release was created.
    • Assuming we can leave example scala notebook as is.
    • Update the readme to specific release info or just point to search.maven.org

import scala.util.Properties

organization := "org.jupyter"

name := "declarativewidgets"

version := "0.1-SNAPSHOT"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbustelo updated the PR. publish jar depends on export release. It uses a file as the intermediary between the two targets. I was having an issue exporting as it was operating in a different shell. Maybe we should treat the version setting differently to avoid this commit.

(c) Copyright IBM Corp. 2016
@poplav poplav force-pushed the add_jar_to_release branch 3 times, most recently from 27e762a to 58d606c Compare July 26, 2016 14:59
-v `pwd`/etc/read_release_version.py:/src/read_release_version.py \
$(REPO) bash -c 'python /src/read_release_version.py' > `pwd`/dist/RELEASE_VERSION

publish-scala-jar: export-release-version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing a dependency... for it to be a standalone, shouldn't it depend on the recipe that builds scala

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added dependency with the latest commit

@poplav poplav force-pushed the add_jar_to_release branch from 58d606c to 913b13d Compare July 27, 2016 20:35
@lbustelo lbustelo merged commit d8ba08a into master Jul 27, 2016
@poplav poplav deleted the add_jar_to_release branch August 4, 2016 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants