Skip to content
This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

Frontend hardcodes python3 #169

Closed
parente opened this issue Apr 6, 2016 · 1 comment
Closed

Frontend hardcodes python3 #169

parente opened this issue Apr 6, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@parente
Copy link
Member

parente commented Apr 6, 2016

Need to make the decision about what language to use server-side after loading the notebook. That, or the server has encode the kernel name in the page template and let the JS echo it back.

I don't know which one is better / worse yet. 💭

@parente parente added the bug label Apr 6, 2016
@parente parente modified the milestone: 0.5.0 Apr 13, 2016
@parente
Copy link
Member Author

parente commented Apr 21, 2016

@jameslmartin want to take a crack at this one next?

Since this was opened, code was added to modify POST /api/kernel requests before they reach the kernel gateway. The fix here would be to get the kernel name (language) from the notebook metadata and replace the {"name" : "kernel_name"} value in the POST request from the frontend with it before it gets proxied to the KG.

@parente parente modified the milestone: 0.6.0 Apr 27, 2016
jameslmartin pushed a commit to jameslmartin/dashboards_server that referenced this issue Apr 28, 2016
(c) Copyright IBM Corp. 2016
jameslmartin pushed a commit to jameslmartin/dashboards_server that referenced this issue Apr 28, 2016
jameslmartin pushed a commit to jameslmartin/dashboards_server that referenced this issue May 16, 2016
(c) Copyright IBM Corp. 2016
jameslmartin pushed a commit to jameslmartin/dashboards_server that referenced this issue May 16, 2016
jhpedemonte pushed a commit to jhpedemonte/dashboards_server that referenced this issue May 18, 2016
(c) Copyright IBM Corp. 2016
jhpedemonte pushed a commit to jhpedemonte/dashboards_server that referenced this issue May 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants