Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the documentations of jupyterlite-xeus-python and xeus-python #601

Merged

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou marked this pull request as ready for review November 9, 2023 09:04
@martinRenou
Copy link
Member Author

Trying to trigger rtd

@martinRenou martinRenou closed this Nov 9, 2023
@martinRenou martinRenou reopened this Nov 9, 2023
@martinRenou
Copy link
Member Author

Not sure I can build PRs with ReadTheDocs that are not against the default branch. Lets merge and iterate.

@martinRenou martinRenou merged commit cf941fe into jupyter-xeus:merge-xeus-python-kernel Nov 9, 2023
@martinRenou martinRenou deleted the merge_docs branch November 9, 2023 09:15
@jtpio
Copy link
Member

jtpio commented Nov 14, 2023

Not sure I can build PRs with ReadTheDocs that are not against the default branch. Lets merge and iterate.

The preview links might be available from the ReadTheDocs admin page?

For example with the jupyterlite-xeus-python kernel setup on RTD:

image

@martinRenou
Copy link
Member Author

Problem is this is not a PR against the main branch, so ReadTheDocs does not build the PR branch.

Anyway this cannot pass until Thorsten finished #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants