Upgraded to xeus-python-shell 0.6.3 (#626)

environment-dev.yml

@@ -12,7 +12,7 @@ dependencies:
   - nlohmann_json=3.11.3
   - pybind11>=2.6.1,<3.0
   - pybind11_json>=0.2.6,<0.3
-  - xeus-python-shell>=0.5.0,<0.6
+  - xeus-python-shell>=0.6.3,<0.7
   - debugpy>=1.6.5
   # Test dependencies
   - pytest

environment-wasm-host.yml

@@ -11,7 +11,7 @@ dependencies:
   - numpy
   - xeus-lite
   - xeus 
-  - xeus-python-shell>=0.5
+  - xeus-python-shell>=0.6.3
   - pyjs>=2.0.0
   - requests-wasm-polyfill>=0.3.0
   - libpython

include/xeus-python/xinterpreter.hpp

@@ -102,6 +102,7 @@ namespace xpyt
     private:
 
         virtual void instanciate_ipython_shell();
+        virtual bool use_jedi_for_completion() const;
     };
 }
 

include/xeus-python/xinterpreter_wasm.hpp

@@ -34,6 +34,10 @@ namespace xpyt
     protected:
 
         void configure_impl() override;
+
+    private:
+
+        bool use_jedi_for_completion() const override;
     };
 
 }

src/xinterpreter.cpp

@@ -80,7 +80,7 @@ namespace xpyt
 
         instanciate_ipython_shell();
 
-        m_ipython_shell_app.attr("initialize")();
+        m_ipython_shell_app.attr("initialize")(use_jedi_for_completion());
         m_ipython_shell = m_ipython_shell_app.attr("shell");
 
         // Setting kernel property owning the CommManager and get_parent
@@ -383,4 +383,8 @@ namespace xpyt
         m_ipython_shell_app = py::module::import("xeus_python_shell.shell").attr("XPythonShellApp")();
     }
 
+    bool interpreter::use_jedi_for_completion() const
+    {
+        return true;
+    }
 }

src/xinterpreter_wasm.cpp

@@ -39,4 +39,8 @@ namespace xpyt
         py::module::import("pyjs");
     }
 
+    bool wasm_interpreter::use_jedi_for_completion() const
+    {
+        return false;
+    }
 }