Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping this updated with @jupyterlab/services #1277

Closed
infinity0 opened this issue Apr 12, 2017 · 8 comments · Fixed by #1296
Closed

Keeping this updated with @jupyterlab/services #1277

infinity0 opened this issue Apr 12, 2017 · 8 comments · Fixed by #1296
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@infinity0
Copy link

This repository depends on @jupyterlab/services version 0.35 but that repo is already on version 0.41.

What are the plans for keeping this up-to-date? That repo says "not suitable for public use" but the fact that you're relying on its typescript definitions means that you're using it as a public API, which I have to figure out how to deal with when trying to package this for Debian.

@jasongrout
Copy link
Member

Thanks for packaging this for Debian!

@blink1073 - what is the status of the @jupyterlab/services repo? Are we close to declaring it stable now?

@infinity0
Copy link
Author

On closer inspection, it looks like the only thing being used is Kernel and KernelMessage so for the time being I'm just bundling these definitions only with the ipywidgets Debian source package, and avoiding packaging the whole of @jupyterlab/services.

In the long run, if it's too hard to make the whole thing stable, it might be worth splitting out the "more stable" parts into another package (with fewer dependencies), and depend on that instead from ipywidgets.

@jasongrout
Copy link
Member

@jupyterlab/services is stable or nearly stable, I think (not that it might not change in the future, but it's a very solid package right now as it is). It may be just a matter of declaring it so. Right now, we're in the process of evaluating a number of jupyterlab packages and deciding the stability of each of them.

@jasongrout
Copy link
Member

(or rather, we're just about to the point where we'll start declaring the status of each package.)

@jasongrout
Copy link
Member

We could also just have our own interfaces for what is passed to display_model and display_view. That's probably better anyway for arbitrary widget managers.

@jasongrout jasongrout added this to the 7.0 milestone Apr 12, 2017
@blink1073
Copy link
Contributor

I would not declare @jupyterlab/services to be close to stable at this point. I had intended to refactor it after we release beta to clean up the handling of server configuration.

@jasongrout
Copy link
Member

@infinity0 - certainly the type definitions we are using are stable - they are given in the jupyter spec. @blink1073 and I were talking about maybe repackaging up those type definitions in a stable package. However, it sounds like you have a workaround for now?

@infinity0
Copy link
Author

Yes, I have a workaround for now so this isn't too urgent. It's not a nice workaround though :p A stable package sounds good, I'd also comment further that if the spec you're talking about is formalised, it might be good for this to be one single package, rather than e.g. have @jupyterlab/services type defs vs other type defs split.

jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Apr 18, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants