Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipyleaflet basemap library modified #924

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

MackyDIARRA
Copy link
Contributor

some basemaps no longer worked in the Ipyleaflet documentation. Therefore I took the initiative to delete them to make the page cleaner.

@martinRenou
Copy link
Member

Thanks a lot! Would you mind undoing the changes on the Notebooks if you can?

@martinRenou
Copy link
Member

martinRenou commented Feb 9, 2022

You can probably do this by using nbconvert and do:

jupyter nbconvert --ClearOutputPreprocessor.enabled=True --inplace examples/*.ipynb

Then commit and push again to your branch :)

@MackyDIARRA
Copy link
Contributor Author

Okay ! I will do that

"metadata": {},
"outputs": [],
"source": [
"from ipyflex import FlexLayout\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding ipyflex to the binder requirements here: https://github.com/jupyter-widgets/ipyleaflet/blob/master/environment.yml ? That way this example will still work on Binder :)

"metadata": {},
"outputs": [],
"source": [
"from ipyflex import FlexLayout\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding ipyflex to the binder requirements here: https://github.com/jupyter-widgets/ipyleaflet/blob/master/environment.yml ? That way this example will still work on Binder :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem !

@martinRenou
Copy link
Member

The CI failing is unrelated. Let's fix this separately. Thanks again!

1 similar comment
@martinRenou
Copy link
Member

The CI failing is unrelated. Let's fix this separately. Thanks again!

@martinRenou martinRenou merged commit c738402 into jupyter-widgets:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants