-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ipyleaflet basemap library modified #924
Conversation
Thanks a lot! Would you mind undoing the changes on the Notebooks if you can? |
You can probably do this by using nbconvert and do:
Then commit and push again to your branch :) |
Okay ! I will do that |
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"from ipyflex import FlexLayout\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding ipyflex
to the binder requirements here: https://github.com/jupyter-widgets/ipyleaflet/blob/master/environment.yml ? That way this example will still work on Binder :)
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"from ipyflex import FlexLayout\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding ipyflex
to the binder requirements here: https://github.com/jupyter-widgets/ipyleaflet/blob/master/environment.yml ? That way this example will still work on Binder :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem !
The CI failing is unrelated. Let's fix this separately. Thanks again! |
1 similar comment
The CI failing is unrelated. Let's fix this separately. Thanks again! |
some basemaps no longer worked in the Ipyleaflet documentation. Therefore I took the initiative to delete them to make the page cleaner.