Added backward compatibility for dict basemaps #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>
Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>
|
Ipyleaflet needs a testsuite... ;) |
PR welcome @deeplook... ;) |
|
We have JupyterLab's Galata now. If you want, you can take a look at what ipywidgets/bqplot do for testing and start from there. We'd be happy to guide you. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kharude, Sachin sachin.kharude@here.com
Hi @martinRenou,
I am not sure why these code changes were not included in my PR #857 . As these are there to handle backward compatibility with the dictionary for basemap_to_tiles function.
Please review this. Without this, it will break if the user passes a simple dictionary as a basemap.
I added these changes in my forked branch but somehow did not see them in the PR.
https://github.com/sackh/ipyleaflet/blob/b741cb5cf9e86ae5f62bd1408de391ae6300b353/ipyleaflet/leaflet.py#L53