Fix cell selection in Jupyter 4.0 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b50a8f1 to
13dd21f
Compare
Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
13dd21f to
d43d91b
Compare
martinRenou
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
Replaced a call to a private Lumino function that stoped being exported: jupyterlab/lumino@f4feada / jupyterlab/lumino#319
The call is replaced with a call to a new copy of the (small) function we were previously calling.
Testing performed
Just manual testing of the selection functionality.
Additional context
This is the bare minimum required to fix the issue in the description.
There are other issues when switching to JupyterLab 4.0. Would it be worth upgrading the dependencies of this library to Lumino or do we want to keep compatibility with older versions of JupyterLab?
This requires #419