Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant pylint check #635

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Dec 9, 2021

significant time savings in pre-commit

pylint was only checking for one issue, which flake8 supports, but skipped in config

remove the skip in flake8 config, so pylint can be removed

@codecov-commenter

This comment has been minimized.

@blink1073
Copy link
Contributor

Thanks! It looks like the flake8 checker found some more unused imports that need updating

significant time savings in pre-commit

pylint was only checking for one issue, which flake8 supports, but skipped

remove the skip in flake8 config, so pylint can be removed
@blink1073 blink1073 added this to the 1.13 milestone Dec 10, 2021
@blink1073 blink1073 merged commit 606487a into jupyter-server:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants