Added control channel to ZMQChannelsHandler #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change makes sense, and is simple enough. However, the dependency on jupyter-client should be updated to require a version that includes jupyter/jupyter_client#447. For that, we'd have to wait not only until that other PR is merged, but also until a new version of jupyter-client has been released afterwards. |
|
Now that jupyter_client is out, I think we can go ahead with this. |
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* add jest test infra * get a basic test running * make build quieter and increase timeout * allow root * try this * try local dir * another attempt at config * try json file * fix manifest * wip test suite * try with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially implements requirement of jupyter/jupyter_client#446
This requires jupyter/jupyter_client#447 to be merged first.