Restore pytest plugin from pytest-jupyter #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In today's Jupyter Server meeting, we discussed deprecating the pytest-jupyter library and moving (back) to a native pytest_plugin in this package (how we originally had it).
The pytest-jupyter library introduced extra complexity, requiring us to coordinate releases of pytest-jupyter and jupyter_server anytime there was a change in jupyter_server.
Here, the pytest_plugin is a submodule in jupyter_server. To use this plugin in a given test suite, add
jupyter_server.pytest_plugin
to the pytest_plugin list of the rootconftest.py
file, e.g.:This PR includes some fixtures that we should eventually move to the
jupyter_core
package as ajupyter_core.pytest_plugin
module. We can do this at a later time. Jupyter Server can remove those fixtures and depend on jupyter_core's plugin without changing API or disrupting downstream projects.