Skip to content

Commit

Permalink
Update typings and fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 committed Oct 25, 2023
1 parent 4cb13ce commit d5ab736
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ nowarn = "test -W default {args}"

[tool.hatch.envs.typing]
features = ["test"]
dependencies = [ "mypy~=1.6", "traitlets>=5.11.2", "jupyter_core>=5.3.2"]
dependencies = [ "mypy~=1.6", "traitlets>=5.11.2", "jupyter_core>=5.3.2", "jupyter_client>=8.5"]
[tool.hatch.envs.typing.scripts]
test = "mypy --install-types --non-interactive {args:.}"

Expand Down
2 changes: 1 addition & 1 deletion tests/auth/test_identity.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def test_password_required(identity_provider_class, password_set, password_requi
app.identity_provider = idp
ctx = nullcontext() if ok else pytest.raises(SystemExit)

with ctx:
with ctx: # type:ignore[attr-defined]
idp.validate_security(app, ssl_options=None)


Expand Down
3 changes: 3 additions & 0 deletions tests/services/sessions/test_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ class DummyKernel:
def __init__(self, kernel_name="python"):
self.kernel_name = kernel_name

def update_env(self, *args, **kwargs):
pass


dummy_date = utcnow()
dummy_date_s = isoformat(dummy_date)
Expand Down

0 comments on commit d5ab736

Please sign in to comment.