Don't await saving files

jupyter-server · Dec 1, 2020 · c35b04a · c35b04a
1 parent b6b4b28
commit c35b04a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 23 deletions.
diff --git a/jupyter_server/services/contents/fileio.py b/jupyter_server/services/contents/fileio.py
@@ -416,24 +416,3 @@ async def _read_file(self, os_path, format):
                         reason='bad format',
                     ) from e
         return encodebytes(bcontent).decode('ascii'), 'base64'
-
-    async def _save_file(self, os_path, content, format):
-        """Save content of a generic file."""
-        if format not in {'text', 'base64'}:
-            raise HTTPError(
-                400,
-                "Must specify format of file contents as 'text' or 'base64'",
-            )
-        try:
-            if format == 'text':
-                bcontent = content.encode('utf8')
-            else:
-                b64_bytes = content.encode('ascii')
-                bcontent = decodebytes(b64_bytes)
-        except Exception as e:
-            raise HTTPError(
-                400, u'Encoding error saving %s: %s' % (os_path, e)
-            ) from e
-
-        with self.atomic_writing(os_path, text=False) as f:
-            await run_sync_in_worker_thread(f.write, bcontent)
diff --git a/jupyter_server/services/contents/filemanager.py b/jupyter_server/services/contents/filemanager.py
@@ -740,7 +740,7 @@ async def save(self, model, path=''):
                     await self.create_checkpoint(path)
             elif model['type'] == 'file':
                 # Missing format will be handled internally by _save_file.
-                await self._save_file(os_path, model['content'], model.get('format'))
+                self._save_file(os_path, model['content'], model.get('format'))
             elif model['type'] == 'directory':
                 await self._save_directory(os_path, model, path)
             else:

diff --git a/jupyter_server/services/contents/largefilemanager.py b/jupyter_server/services/contents/largefilemanager.py
@@ -96,7 +96,7 @@ async def save(self, model, path=''):
                 if chunk == 1:
                     self.log.debug("Saving %s", os_path)
                     self.run_pre_save_hook(model=model, path=path)
-                    await super(AsyncLargeFileManager, self)._save_file(os_path, model['content'], model.get('format'))
+                    super(AsyncLargeFileManager, self)._save_file(os_path, model['content'], model.get('format'))
                 else:
                     await self._save_large_file(os_path, model['content'], model.get('format'))
             except web.HTTPError: