Fix minor issues in Developer and Contributor docs #74
+20
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Mar 24, 2023
Comment on lines
10
to
11
| the user wishes to extend the image with additional libraries to prevent the need to import them within | ||
| the Notebook interactions. Since the image already meets the |
There was a problem hiding this comment.
I think this wording was improper originally. The idea behind adding the libraries to the image is to prevent their installation during notebook interactions. They need to be imported regardless. So perhaps something like:
Suggested change
| the user wishes to extend the image with additional libraries to prevent the need to import them within | |
| the Notebook interactions. Since the image already meets the | |
| the user wishes to extend the image with additional libraries to prevent the need to install them during | |
| the Notebook's execution. Since the image already meets the |
There was a problem hiding this comment.
Yeah I figured that was sort of what this sentence was getting at but didn't want to completely overhaul it. Your suggestion makes it perfectly clear, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final installment! Once again, nothing major found!